test(core): Use a fake global state for integ/e2e tests #6565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTests |
1 similar comment
Contributor
Author
|
/runIntegrationTests |
jpinkney-aws
force-pushed
the
fake-global-state
branch
from
a6e4100 to
dcfbbb1
Compare
Contributor
Author
|
/runIntegrationTests |
1 similar comment
Contributor
Author
|
/runIntegrationTests |
justinmk3
approved these changes
Feb 13, 2025
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
We may want to start thinking about a base-class for test/globalSetup.ts and testInteg/globalSetup.ts. Seems like there is a lot of overlap.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Features that depend on global state can cause test failures locally because the tests will use your current global state settings instead of a fake state for integ/e2e tests ## Solution integ/e2e tests should use a fake global state instead that automatically gets reset after each test --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Features that depend on global state can cause test failures locally because the tests will use your current global state settings instead of a fake state for integ/e2e tests
Solution
integ/e2e tests should use a fake global state instead that automatically gets reset after each test
feature/xbranches will not be squash-merged at release time.